Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Hash::zero() to Hash::default() #858

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Rename Hash::zero() to Hash::default() #858

merged 1 commit into from
Mar 23, 2018

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Mar 23, 2018

It is more idiomatic, also zero is misleading in context of +
operator.

Rename Hash::zero() to Hash::default()
05111b8 
It is more idiomatic, also `zero` is misleading in context of `+`
operator.
@ignopeverell ignopeverell merged commit bb13475 into mimblewimble:master Mar 23, 2018
@hashmap hashmap deleted the hash_default branch September 4, 2018 08:54
dpc pushed a commit to dpc/grin that referenced this pull request Oct 24, 2018
@hashmap @dpc
Rename Hash::zero() to Hash::default() (mimblewimble#858)
844f8f6 
It is more idiomatic, also `zero` is misleading in context of `+` operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @ignopeverell